Closed egordon closed 3 years ago
Heads up: I changed the base branch to your GH actions one so we can see a better diff.
This seems mostly fine, I just left two comments: I'm a bit confused since those changes don't seem to relate to WorldInteractiveMarkerViewer -> InteractiveMarkerViewer
@sniyaz Responded for review comments and updated CHANGELOG. Ready for re-review
Aikidopy relies on the deprecated WorldInteractiveMarkerViewer which was removed in https://github.com/personalrobotics/aikido/pull/521
This updates that interface.
Note: this depends on #598 , as this should fix the one failing (not required) test.
Before creating a pull request
make format
Before merging a pull request
CHANGELOG.md