personalrobotics / aikido

Artificial Intelligence for Kinematics, Dynamics, and Optimization
https://personalrobotics.github.io/aikido/
BSD 3-Clause "New" or "Revised" License
213 stars 30 forks source link

Aikidopy uses outdated WorldInteractiveMarker #599

Closed egordon closed 3 years ago

egordon commented 3 years ago

Aikidopy relies on the deprecated WorldInteractiveMarkerViewer which was removed in https://github.com/personalrobotics/aikido/pull/521

This updates that interface.

Note: this depends on #598 , as this should fix the one failing (not required) test.


Before creating a pull request

Before merging a pull request

sniyaz commented 3 years ago

Heads up: I changed the base branch to your GH actions one so we can see a better diff.

This seems mostly fine, I just left two comments: I'm a bit confused since those changes don't seem to relate to WorldInteractiveMarkerViewer -> InteractiveMarkerViewer

egordon commented 3 years ago

@sniyaz Responded for review comments and updated CHANGELOG. Ready for re-review