search

personalrobotics / apriltags

ROS wrapper for the Apriltags visual fiducial tracker
BSD 2-Clause "Simplified" License
39 stars 37 forks source link

Added CGAL dependency #15

Closed mkoval closed 8 years ago

mkoval commented 8 years ago

CGAL is technically an optional dependency. However, building Apriltags without CGAL results in it spamming this warning message to the console:

*** WARNING: NEW QUAD ALGORITHM REQUESTED, BUT COMPILED WITHOUT CGAL SUPPORT, FALLING BACK TO OLD ALGORITHM. ***
psigen commented 8 years ago

Should we consider any other apriltags implementations?

mkoval commented 8 years ago

I'm not sure what you mean. Isn't this code fundamentally tied to the Swatbotics implementation?

psigen commented 8 years ago

Only about 20 lines of it directly deal with apriltags. The vast majority of this code is just the ROS boilerplate to get the detections in and out.

mkoval commented 8 years ago

I am fine with you adding other backends, but I would like this pull request to be merged. :smile: