Moved the discussion in this comment as the PR is closed:
GENERATED_SOURCES_VAR is added by #304 (and renamed by #318) to make it easier to get the list of generated binding sources (instead of doing this). This variable would be useful when the user wants to (1) split the Python binding compile process into binding generation and compiling the generated source (e.g., dartpy) and (2) format the generated source (using ClangFormat).
However, this list can be obtained by get_target_property(GENERATED_SOURCES my_chimera_target SOURCES) (see this comment).
I'd be okay to remove this variable if (a) we document about get_target_property in the add_chimera_binding() docstring or/and (b) (1) is addressed by resolving https://github.com/personalrobotics/chimera/issues/317.
Moved the discussion in this comment as the PR is closed:
GENERATED_SOURCES_VARis added by #304 (and renamed by #318) to make it easier to get the list of generated binding sources (instead of doing this). This variable would be useful when the user wants to (1) split the Python binding compile process into binding generation and compiling the generated source (e.g., dartpy) and (2) format the generated source (using ClangFormat).However, this list can be obtained by
get_target_property(GENERATED_SOURCES my_chimera_target SOURCES)(see this comment).I'd be okay to remove this variable if (a) we document about
get_target_propertyin theadd_chimera_binding()docstring or/and (b) (1) is addressed by resolving https://github.com/personalrobotics/chimera/issues/317.