Describe this pull request. Link to relevant GitHub issues, if any.
Currently, once the robot/app gets to the staging configuration (R_DetectingFace in the app), the user must continue to their mouth. However, there are multiple cases where they won't want to, e.g.,
From the resting configuration, the user wanted to go back above the plate but clicked the wrong button.
MoveToMouth returns failure, but it is actually at the user's mouth. At this point, the user must click "Back" to go back, but then the "DetectingFace" screen needs to allow them to go back.
This PR adds two additional buttons to the R_DetectingFace page, to move to the resting configuration and to move back to the above plate configuration.
The above image shows the screen before this PR.
The above image shows the screen after this PR.
Explain how this pull request was tested, including but not limited to the below checkmarks.
[x] ros2 run ada_feeding_perception republisher --ros-args --params-file src/ada_feeding/ada_feeding_perception/config/republisher.yaml
[x] cd src/feeding_web_interface/feedingwebapp/; npm start
[x] Testing:
[x] Navigate to the Detecting Face page. Press each of the below buttons and verify that everything works as expected.
[x] Continue
[x] Move to Resting
[x] Move Above Plate
[x] On the DetectingFace page, try it with multiple different devices, orientations, and sizes. Some guidelines are here.
Before creating a pull request
[x] Format React code with npm run format
[N/A] Format Python code by running python3 -m black . in the top-level of this repository
[x] Thoroughly test your code's functionality, including unintended uses.
[see above] Fully test the responsiveness of the feature as documented in the Responsiveness Testing Guidelines. If you deviate from those guidelines, document above why you deviated and what you did instead.
[x] Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.
Before merging a pull request
[ ] Squash all your commits into one (or Squash and Merge)
Describe this pull request. Link to relevant GitHub issues, if any.
Currently, once the robot/app gets to the staging configuration (
R_DetectingFacein the app), the user must continue to their mouth. However, there are multiple cases where they won't want to, e.g.,MoveToMouthreturns failure, but it is actually at the user's mouth. At this point, the user must click "Back" to go back, but then the "DetectingFace" screen needs to allow them to go back.This PR adds two additional buttons to the
R_DetectingFacepage, to move to the resting configuration and to move back to the above plate configuration.Explain how this pull request was tested, including but not limited to the below checkmarks.
ros2 launch feeding_web_app_ros2_test feeding_web_app_dummy_nodes_launch.xmlros2 run ada_feeding_perception republisher --ros-args --params-file src/ada_feeding/ada_feeding_perception/config/republisher.yamlcd src/feeding_web_interface/feedingwebapp/; npm startBefore creating a pull request
npm run formatpython3 -m black .in the top-level of this repositoryBefore merging a pull request
Squash and Merge)