Describe this pull request. Link to relevant GitHub issues, if any.
This PR, Motivated by the 2024 deployment, creates the option to show the video feed in the Teleop modal. In practice, this works fine when the user is accessing the modal on their computer, but not great on a screen as smart as the smartphone. Thus, by default, we disable this.
Explain how this pull request was tested, including but not limited to the below checkmarks.
[x] Run it, open the teleop modal, verify the video stream doesn't show.
[x] Change showVideoFeedDuringTeleop's default value to true, run it, verify it does show.
Before creating a pull request
[x] Format React code with npm run format
[N/A] Format Python code by running python3 -m black . in the top-level of this repository
[x] Thoroughly test your code's functionality, including unintended uses.
[x] Fully test the responsiveness of the feature as documented in the Responsiveness Testing Guidelines. If you deviate from those guidelines, document above why you deviated and what you did instead.
[x] Consider the user flow between states that this feature introduces, consider different situations that might occur for the user, and ensure that there is no way for the user to get stuck in a loop.
Before merging a pull request
[ ] Squash all your commits into one (or Squash and Merge)
Describe this pull request. Link to relevant GitHub issues, if any.
This PR, Motivated by the 2024 deployment, creates the option to show the video feed in the Teleop modal. In practice, this works fine when the user is accessing the modal on their computer, but not great on a screen as smart as the smartphone. Thus, by default, we disable this.
Explain how this pull request was tested, including but not limited to the below checkmarks.
showVideoFeedDuringTeleop
's default value to true, run it, verify it does show.Before creating a pull request
npm run format
python3 -m black .
in the top-level of this repositoryBefore merging a pull request
Squash and Merge
)