personalrobotics / feeding_web_interface

Web interface for the robot-assisted feeding system
1 stars 0 forks source link

Update `rosbridge_suite` and `roslibjs` #97

Open amalnanavati opened 1 year ago

amalnanavati commented 1 year ago

Upstream changes to make rosbridge_suite compatible with ROS2 actions have already been merged in, and there is an open PR to do the same for roslibjs. Once that is merged in, we should update our system to use the upstream code. (Note: we have to use this together, because there were some additional changes in the upstream PR for rosbridge_suite e.g., renaming send_goal to send_action_goal.)

amalnanavati commented 9 months ago

Update: although ROS2 actions support has been merged into rosbridge and roslibjs, there is still a lingering issue where asynchronous action cancellation is not possible if that action was also initiated by the web app. Thus, we have to wait until that issue is resolved before switching to the upstream code.