Remove rogue tests that are just testing motion planning

personalrobotics / herbpy

Python library for interacting with HERB.

BSD 3-Clause "New" or "Revised" License

5 stars 7 forks source link

Remove rogue tests that are just testing motion planning #115

Closed rachelholladay closed 7 years ago

rachelholladay commented 7 years ago

Most of the RoGuE tests are just running TSRs, which doesn't make a lot of sense because the point of their existence should not be to stress test our planners.

psigen commented 7 years ago

Isn't the point of these tests to sanity check that the RoGuE function calls actually do something, and don't just crash due to silly stuff like committing syntax errors or changing the function arguments?

rachelholladay commented 7 years ago

@psigen While I agree in theory, these tests end up actually testing if a TSR can be successfully planned. So theses tests are failing because planning failed, not because there is a syntax bug. One option would be to catch a planning failure, if you think that's a good idea?

psigen commented 7 years ago

I guess it depends on why planning is failing.

Is the TSR planning failing because it is non-deterministic? If so, maybe it would be possible to plan without collision checking or similarly change the planning call to always succeed.
If it is failing because of an upstream bug in TSRs, then failure is probably a legitimate result.

Otherwise, I suppose checking for a PlanningError might be alright, although then you risk missing bugs where an internal parameter is making one of your actions always fail.

Shushman commented 7 years ago

Merging to prevent herbpy build from failing. Test fixes can be seen to later.