search

personalrobotics / herbpy

Python library for interacting with HERB.
BSD 3-Clause "New" or "Revised" License
5 stars 7 forks source link

Feature/generic tsrs #89

Closed jeking04 closed 8 years ago

jeking04 commented 8 years ago

This PR removes the bowl, plate and tray TSRs that are fairly specific to table clearing. It also updates several TSRs to use generic TSRs added as part of prpy PR 309:

https://github.com/personalrobotics/prpy/pull/309

jeking04 commented 8 years ago

I believe I have now addressed all the comments on this PR. The checks are failing because of the dependency on prpy #309. But I have verified tests pass locally. Once we merge the prpy PR we can restart the travis checks and then this PR should be good to go.

mkoval commented 8 years ago

This pull request now contains #95. Is that intentional?

Otherwise, I'm happy with this pull request. I will merge it once @ClintLiddick signs on #95 and we merge that pull request.

jeking04 commented 8 years ago

It is intentional. We needed the changes in both PRs for some testing so we pulled #95 into this one. We should merge #95 first.