Changed cylinder radius to match InteractiveMarker spec.

personalrobotics / or_rviz

OpenRAVE viewer plugin that publishes the environment to RViz as InteractiveMarkers.

BSD 2-Clause "Simplified" License

5 stars 5 forks source link

Changed cylinder radius to match InteractiveMarker spec. #26

Closed psigen closed 9 years ago

psigen commented 9 years ago

Currently, cylinder primitives are rendered at one fourth their normal diameter due to a bug in the conversion to an interactive marker. This PR changes the scaling to match the InteractiveMarker spec.

From http://wiki.ros.org/rviz/DisplayTypes/Marker#Cylinder_.28CYLINDER.3D3.29

scale.x is diameter in x direction, scale.y in y direction, by setting these to different values you get an ellipse instead of a circle. Use scale.z to specify the height.

mkoval commented 9 years ago

Good catch!

mklingen commented 9 years ago

Excellent.