personalrobotics / or_rviz

OpenRAVE viewer plugin that publishes the environment to RViz as InteractiveMarkers.
BSD 2-Clause "Simplified" License
5 stars 5 forks source link

Redundant lighting washes out mesh colors. #28

Closed psigen closed 8 years ago

psigen commented 9 years ago

When using ROS Indigo or_rviz in-process, the default lighting in RViz is not removed before adding the additional lights here:

https://github.com/personalrobotics/or_rviz/blob/732d4c3e40ba0d73f86042835d3a56a6319cc6ed/src/RVizViewer.cpp#L417

This makes the entire scene incredibly washed out. Most meshes are nearly pure white.

mklingen commented 8 years ago

isn't an issue for herb, but I guess other meshes have too much light. I will look into just deleting the existing light.

mklingen commented 8 years ago

this commit https://github.com/personalrobotics/or_rviz/commit/0b5244d3f3472f7ac9735205b5502c4189f4d270 added some lighting options in the environment display which should make this more acceptable to your needs.

http://i.imgur.com/amtkvot.png

psigen commented 8 years ago

yay! :+1: