personalrobotics / or_trajopt

OpenRAVE plugin to expose TrajOpt code as an OpenRAVE planner
BSD 3-Clause "New" or "Revised" License
2 stars 3 forks source link

Disable PlanToEndEffectorOffset by default #11

Closed mkoval closed 8 years ago

mkoval commented 8 years ago

This pull request disables PlanToEndEffectorOffset by default unless you explicitly pass the allow_untested flag. This came out of the discussion in https://github.com/personalrobotics/prpy/pull/213, where we discovered that this method can return trajectories that are in collision and/or violate constraints.

psigen commented 8 years ago

This is superseded by https://github.com/personalrobotics/or_trajopt/pull/14, which simply removed the entire function because it doesn't work anyway. I prefer this to adding unnecessary flags.