search

personalrobotics / or_trajopt

OpenRAVE plugin to expose TrajOpt code as an OpenRAVE planner
BSD 3-Clause "New" or "Revised" License
2 stars 3 forks source link

Removed broken PlanToTSR implementation #25

Closed mkoval closed 7 years ago

mkoval commented 7 years ago

PlanToTSR was previously "disabled" by commenting out the @PlanningMethod decorator. This leads to confusion on a few fronts:

  1. It looks like the method is implemented, but MetaPlanners will not call it.
  2. Calling the method manually results in using the Robot from the wrong (non-cloned) Environment.
  3. The current implementation does not work very well.

I would like to delete the function entirely until we resolve these issues, e.g. in #20.

psigen commented 7 years ago

Sure, can you fix the merge from your other PR?

mkoval commented 7 years ago

Done!