search

personalrobotics / or_urdf

OpenRAVE plugin for loading URDF and SRDF files.
BSD 3-Clause "New" or "Revised" License
19 stars 32 forks source link

Adding tests and deleting old manifest #15

Closed Shushman closed 9 years ago

Shushman commented 9 years ago

Changes:

mkoval commented 9 years ago

Good start. Thanks!

mkoval commented 9 years ago

Actually, please:

  1. Add python and python-nosetest as <test_depend>s in the package.xml file
  2. Register the tests in the CMakeLists.txt file
  3. Restore the manifest.xml file - we will remove that in a separate, atomic pull request

See our unit testing guide for details about (1) and (2).

@Shushman Can you take care of this?

Shushman commented 9 years ago

@mkoval I've addressed the changes. Note that to successfully run the tests, the user must source /opt/ros/indigo/setup.bash and the workspace as well. That is supposed to be the case, right?

mkoval commented 9 years ago

Thanks @Shushman!

mkoval commented 9 years ago

Whoops, I forgot to answer your question:

Note that to successfully run the tests, the user must source /opt/ros/indigo/setup.bash and the workspace as well. That is supposed to be the case, right?

That's fine. Anything in the workspace can safely assume that the user sourced the containing workspace's setup.bash file. Some executables may work despite this, but there are no guarantees.

You should not have to explicitly source /opt/ros/indigo/setup.bash because your workspace is (directly or indirectly) chained from it. To be safe, you should only ever source one setup.bash file per terminal window. This includes the one in /opt/ros/indigo.