search

personalrobotics / rewd_controllers

master
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

Velocity Upper Limit #35

Closed egordon closed 4 years ago

egordon commented 5 years ago

Blocking #34

gilwoolee commented 5 years ago

Why are we mixing two different PRs here? A lot of files here seem unrelated to the velocityLimit fix. Can we separate those out, or base this PR to another PR that handles those changes?

egordon commented 5 years ago

@gilwoolee Everything in this PR is related to the velocity limit fix except for the changes to Travis.

However, those changes need to be in this PR in order for us to be able to pass Travis checks.

egordon commented 5 years ago

@gilwoolee Cherry-picked Travis stuff into #36 .

egordon commented 5 years ago

@brianhou @gilwoolee Ready for re-review!