personalrobotics / rewd_controllers

master
BSD 3-Clause "New" or "Revised" License
3 stars 4 forks source link

Move until touch + refactor #5

Closed ClintLiddick closed 8 years ago

ClintLiddick commented 8 years ago

Refactored trajectory controller to extract JointTrajectoryControllerBase and make it thread and realtime safe in all preemption, cancelation, and multiple trajectory request situations, which is especially necessary when adding an additional end condition from the force/torque sensor.

Current status:

ClintLiddick commented 8 years ago

Done! MoveUntilTouchController is implemented and tested on HERB. There is probably still some issue with the final desired-state, which is currently just setting desired velocity and acceleration to zero. However, since the controller should be immediately unloaded after completion (as is done by herbpy), this shouldn't be a problem in practice.

@mkoval @OrenSalzman @Shushman @jslee02: You're all people who have previously or have offered to review controller code. I'm going to merge these pull requests and clean up the branches, and then request that some of you review the code in its entirety.