personium / personium-core

Core module of Personium
https://personium.io
Apache License 2.0
88 stars 16 forks source link

Unify the setting place of path where event log is saved. #126

Closed SawamiWataru closed 1 year ago

SawamiWataru commented 6 years ago

Current specifications.


eventログの書き込みと読み込みでそれぞれ異なる設定箇所のPathを参照している。 今はデフォルトで同一の設定になっているので問題ないが、ユーザがどちらかを修正すると正常に動作しなくなる。 修正:https://github.com/KourokiTakuto/personium-core/commit/1b2aa0735b05da3fbc7243f00f1d860afe1821c7 でcoreとしての修正は完了しているが、logback.xmlの修正によりansibleにも影響が出る。同時にリリースが必要。

SawamiWataru commented 5 years ago

It is difficult to fix where you are reading logback.xml. I think that the following policy is good.

The related sources are as follows.

KourokiTakuto commented 5 years ago

The logback.xml setting value variable has been modified to refer to personium-unit-config.properties. It is necessary to modify "Ansible" logback.xml. Correct it also when modifying large "Ansible".

yoh1496 commented 1 year ago

How about making eventlog_path contain /personium_nfs/personium-core/eventlog/ and pass entire event log path which is loaded from personium-unit-config.properties ?

https://github.com/personium/personium-core/blob/v1.8.1/src/main/resources/logback.xml#L62

before

<file>/personium_nfs/personium-core/eventlog/${eventlog_path}/current/default.log</file>

after

<file>${eventlog_path}/current/default.log</file>

https://github.com/personium/personium-core/blob/v1.8.1/src/main/java/io/personium/core/rule/action/LogAction.java#L80