personium / personium-core

Core module of Personium
https://personium.io
Apache License 2.0
88 stars 16 forks source link

Incorrect argument is passed to constructor ODataResource(). #44

Closed nisiguti closed 7 years ago

nisiguti commented 7 years ago

It is necessary to add '/' after getUrl().

https://github.com/personium/personium-core/blob/master/src/main/java/io/personium/core/rs/box/ODataSvcCollectionResource.java#L58 https://github.com/personium/personium-core/blob/master/src/main/java/io/personium/core/rs/box/ODataSvcSchemaResource.java#L80-L82

shimono commented 7 years ago

Could you add information about why it is necessary? I guess some API may be returning strange URL like: https://example.com/john/box1/col//odata/entset

nisiguti commented 7 years ago

Current value of rootUrl member in ODataResource class is as follows. https://example.com/john/box1col/ But any trouble has not occurred, because this rootUrl is not used currently.

SawamiWataru commented 7 years ago

Solved in v1.5.4.