search

personium / personium-core

Core module of Personium
https://personium.io
Apache License 2.0
88 stars 16 forks source link

PUT for WebDAV file does not accept If-None-Match header #484

Open Yonezawa-T2 opened 5 years ago

Yonezawa-T2 commented 5 years ago

PUT for WebDAV file should accept If-None-Match: * and return error if a file exists. https://personium.io/docs/en/apiref/current/312_Register_and_Update_WebDAV.html https://tools.ietf.org/html/rfc7232#section-3.2

This can be used to “create a file only if not exists”.

tochi-y commented 5 years ago

Thank you for raising the issue. When personium project started in 2012, RFC7232 did not exist. So early codes don't comply with it. We think it should be compliant to RFC as you commented. We are willing to modify the code so that it comply with RFC in the future. But your pull request is always welcomed.

Yonezawa-T2 commented 5 years ago

If-None-Match: * has been a part of HTTP/1.1 from January 1997, when the first RFC of HTTP/1.1 is issued at.

https://tools.ietf.org/html/rfc2616#section-14.26 https://tools.ietf.org/html/rfc2068#section-14.26

tochi-y commented 5 years ago

Moved to 1.7.21 for the issue personium/personium-engine#119.