search

personium / personium-engine

Additional module for personium-core to enable server-side JavaScript execution.
Apache License 2.0
16 stars 7 forks source link

Implement bar install function in engine script #149

Closed yoh1496 closed 3 years ago

yoh1496 commented 3 years ago

I added reference to installBox function onto personium-dao.js.

Test is placed to ScriptTest#barInstallTest. The test consist of 4 parts as below.

  1. Place bar file in same box as engine script and set ACL to all:read .
  2. Install bar from stream (with getStream function) and delete installed box.
  3. Install bar from URL(fetching bar file with HTTP) and delete installed box.
  4. Delete bar file and others.

This PR contains some other refinement. Please review it.

yoh1496 commented 3 years ago

All tests are done. Could you review this again? (See also https://github.com/personium/personium-client-java/pull/62 please)

Because of rebasing, the commit log became large. I think it shoud be merged with Squash and merge