search

personium / setup-vagrant

Vagrantfile and ansible for setting up of personium.io
Apache License 2.0
4 stars 9 forks source link

Change the execution order of tasks that create unitadmin_account #26

Open KourokiTakuto opened 5 years ago

KourokiTakuto commented 5 years ago

Overview
Required unitadmin_account is not created if optional task fails

Hot Fixes If an optional task fails, it is better to generate logs and messages (how to solve the problem) and proceed to the next task.

Repletion The current vagrant carries out the following optional tasks (Git cloning, construction, deployment) separately from the existing ansible. httpclient ← Required mailsender ← Option slack messenger ← Required ew services ← Required unit-manager ← Option Other apps ← Option

dixonsiu commented 5 years ago

Changing the order will not solve similar problem. It should be done the right way.

Suggestion

  1. Execute an optional task and check the result.
  2. If it fails, produce log and message (how to fix the problem).
  3. Execute other task.

Advance Should use the Cell Import feature to setup the App Cell.

KourokiTakuto commented 5 years ago

Since we modified the App cell to use cell import function, correspondence of advance part is unnecessary. https://github.com/personium/setup-vagrant/pull/28/files

KourokiTakuto commented 5 years ago

The option or required is described below:

  1. httpclient : Required
  2. mailsender : Optional
  3. slack messenger : Required
  4. ew services : Required
  5. unit-manager : Optional
  6. Other application : Optional