search

personium / website

Website and Documentation for personium.io
https://personium.io
2 stars 5 forks source link

CHORES: Update communication tool information #142

Closed dixonsiu closed 2 years ago

dixonsiu commented 2 years ago

Replace icons and invitation URL of Slack with Discord's.

Closes #141

yoh1496 commented 2 years ago

Is there no need to modify files in website/static/legacy-docs and website/static/locales folders?

dixonsiu commented 2 years ago

I don't think the legacy-docs is accessible actively by current website.

dixonsiu commented 2 years ago

New search shows Slack URL information in locales folder which are not used in current website. I think i18n is used in the older version of the website.

dixonsiu commented 2 years ago

@yoh1496 I think it is better to remove the sentences with Slack URL just to avoid confusion. I will commit the changes now.

yoh1496 commented 2 years ago

https://github.com/personium/website/blob/master/website/static/locales/ja/translation.json#L94

I thought this is remaining yet. Doesn't this effects anywhere ?

dixonsiu commented 2 years ago

I search the whole statics folder, the i18n key is never used. I think it belongs to the old version of the website.

But let's remove the content (like the legacy-docs). I will commit in 15 minutes.

Thanks for the review!

yoh1496 commented 2 years ago

I don't think the legacy-docs is accessible actively by current website.

I thought legacy-docs is accessible from search engine, but I re-search in Google and I found it is not shown in list anymore.

Maybe, we can erase legacy-docs from this repository.

dixonsiu commented 2 years ago

Agree, I will create a new issue to delete the legacy-docs.

144