personnummer / swift

Validate Swedish personal identity numbers
MIT License
4 stars 4 forks source link

Add coordination number flag. #5

Open frozzare opened 5 years ago

frozzare commented 5 years ago

We need a flag on the ::Valid method making it possible to turn of validation for coordination number (+60 on day). The flag should default to enabling them as that is how it is currently working.

See https://github.com/personnummer/meta/issues/9 for meta discussion.

arbitur commented 4 years ago

Just out of curiosity, why would someone want to disable "samordningsnummer"?

frozzare commented 4 years ago

@arbitur not sure why.. https://github.com/personnummer/python/issues/5

arbitur commented 4 years ago

That issue was created by someone not aware of what samordningsnummer is, I'd say it worked as intended for him. I vote against adding this flag.

frozzare commented 4 years ago

Maybe, but it may be case where you want to disable this and we have a spec to follow for all implementations (see meta repo). It's not a big thing.

arbitur commented 4 years ago

Oh, I wasn't aware of the meta repo. I guess it's already settled then 👍

arbitur commented 4 years ago

I see now that I complettely missed you linked to meta.....