persvr / perstore

CommonJS persistence/object storage based on W3C's object store API.
http://www.persvr.org/
96 stars 20 forks source link

directives not passed when using .add() in facet.js #33

Closed dmachi closed 12 years ago

dmachi commented 12 years ago

In facet.js' construction.post method, if (!directives.id), the call to this.add doesn't pass the directives object (even if there are other directives). Unless there is some reason to specifically exclude this, it should be 'return this.add(props, directives)' instead of 'return this.add(props)'.

neonstalwart commented 12 years ago

do you mean this https://github.com/persvr/perstore/commit/40c8a51d5b53eb89d1104e88404d935422e62727 ;)