Closed sebastianst closed 1 month ago
Having just a string
allowing for detailed explanations of each stage might even be better. We opted for the simple approach on the beginning because more was not necessary.
Thinking back at how we would like to display information on the stages in NERD though makes string
s better.
Related, I thought about adding an optional argument displayProgress?: function(message string, fractionDone number)
to functions that perform complex multi-stage operations. A frontend component could then inject such a progress displayer when calling, e.g., leave
.
Part of #158.
@ndzik explained to me that it's about differentiating the different calls during deposits. Wouldn't it then actually make sense to replace
StageName
by just astring
and then write something more specific into it, likeerc721/${tokenAddr}/{id}/approve
orerc20/${tokenAddr}/approve
etc? Because if deposit is called on multiple assets, only knowing that it's anapproval
ordeposit
call is ambiguous. Anyway, we can think about this in a later issue._Originally posted by @sebastianst in https://github.com/perun-network/erdstall-ts-sdk/pull/119#discussion_r752150872_