perun-network / erdstall-ts-sdk

TypeScript client SDK to interact with Erdstall.
Apache License 2.0
5 stars 2 forks source link

transactions/trade: Add SignedTradeOffer Closes #98 #130

Open Ruben-Kruepper opened 2 years ago

sebastianst commented 2 years ago

Like mentioned in the original issue, the idea was to ultimately improve the type safety in the backend server. For the trading API, trade offers are saved into a mapping of TradeOffers. Then when a trade offer is executed, it it currently asserted that the offer has a sig. Please check if this can be improved, so that incoming trade offers are checked for non-nil sigs and then saved into a mapping of SignedTradeOffers.