perun-network / erdstall-ts-sdk

TypeScript client SDK to interact with Erdstall.
Apache License 2.0
5 stars 2 forks source link

Add `.equals(...)` methods to Erdstall base types #26

Open ndzik opened 3 years ago

ndzik commented 3 years ago

To aid the intuition of developers using our SDK we should strive to use a familiar API for our types.

{Asset|Assets} includes a cmp(...) method, while types like Address and BigInteger implement an equals method.

I propose to add the equals method where possible. Currently that would be in {Asset|Assets}.

See also here.