Added wallet functions - Githubissues

perun-network / perun-eth-mobile

:iphone: Mobile bindings for two-party-payment channels on Ethereum using go-perun.

https://perun.network/

Apache License 2.0

5 stars 3 forks source link

Added wallet functions #12

Closed ggwpez closed 4 years ago

ggwpez commented 4 years ago

Added

CreateAccount(keystorePath, password string) (*Address, error)
ImportAccount(keystorePath, password, secretKey string) (*Address, error)

ggwpez commented 4 years ago

Using the standard scrypt parameters on Android is slower than on PC and since it has to unlock the wallet twice at startup right now, the App crashes after 9 seconds of startup time. Steffen said that Android probably stops Apps when they dont react withing a given time after startup.
So i need to fix the Java app before being able to test this with standard parameter.

sebastianst commented 4 years ago

If you implement the wallet wrapper type as suggested in my review comment, there's only one unlock happening. Also, you changed the parameters from2, 1 to the keystore.StandardScrypt(N,P) standard ones, which causes the long startup time now.

I think we should just use 2, 1 here for the time being. If this code is ever to be used in production, we make the parameters configurable.