search

perusio / drupal-with-nginx

Running Drupal using nginx: an idiosyncratically crafted bleeding edge configuration.
855 stars 246 forks source link

Review request #259

Open iryston opened 7 years ago

iryston commented 7 years ago

Hi, @perusio

Can you take a look at my fork I've made total synchronisation between branches, and publish them as D6-SYNC, D7-SYNC and master-SYNC. If you don't have objection for this work, I'll do pull request.

One serious change which can break working sites is 'Rename poll, status and ping'

All other changes are most cosmetic and typo fixes.

Regards, Igor

kkomelin commented 7 years ago

Hi @iryston ,

I think you've done a great job. I would recommend you splitting your changes into separate independent features and create corresponding pull requests (PRs) to make code review easier.

iryston commented 7 years ago

@kkomelin Thanks for recommendations. I'll recreate it in separate pull requests.

andypost commented 6 years ago

Please recreate