peruskallio / c5_asset_pipeline

Asset Pipeline implementation for concrete5.
MIT License
11 stars 2 forks source link

Make add-on compatible with concrete5 version 8.0.0 #3

Open Kaapiii opened 7 years ago

Kaapiii commented 7 years ago

Fix various issues with concrete5 version 8.0.0:

Kaapiii commented 7 years ago

By the way. The pull request fixes the issues #1 and #2.

@ahukkanen There doesn't seem to be a real effort in implementing Assetic or similar solution into concrete5. If you plan to maintain this package further, I'm willing to contribute.

ahukkanen commented 7 years ago

@Kaapiii Thanks really much putting effort into this! I will take a look at this in the upcoming weeks and merge in if everything seems OK.

I guess people doing development on Sass are mostly compiling it using node based solutions (and I guess core team is mostly using Less) why there isn't that much of a push for this. I still think eventually this (or similar alternative) should be part of the core as this also allows people to use node based compilers.

They have been open to the idea (why the issue is still open), so if there would a core pull request that swaps the built in compiler to an Assetic based solution preserving backwards compatibility, I think they might look closely into it.

Kaapiii commented 7 years ago

@ahukkanen You're welcome. Just let me know, if I should change some thing.

herent commented 6 years ago

Was this ever merged? I'm looking to use this package for a v8.3.2 site to process scss files. I could just compile locally which is what I'm doing, but it would be nice to be able to have the core just handle compilation.

Kaapiii commented 6 years ago

No, this was never merged. For my current projects with concrete5 8.3.2 I'm still using the version from my branche