pervognsen / bitwise

Bitwise is an educational project where we create the software/hardware stack for a computer from scratch.
Other
5.13k stars 213 forks source link

Add number groupings #29

Closed uucidl closed 6 years ago

uucidl commented 6 years ago

Two small patches, the first is a bugfix, the second is a proposal to add _ as number grouping separator to allow literals such as:

0x1200_00e0 123_456_789

uucidl commented 6 years ago

(Sorry, just saw that there was a "no proposal" clause in the guidelines) In any case feel free to drop, and treat the first commit as a (small) defect report

pervognsen commented 6 years ago

Thanks for the report and the proposed fix. I did a slightly different fix myself. As for the proposal, I'll consider it in the future.