search

perwendel / spark-template-engines

Repository for different Template engine implementations.
Apache License 2.0
134 stars 101 forks source link

Updates spark-template-pebble for 2.x.x for #32 #33

Closed kagolaub closed 8 years ago

kagolaub commented 8 years ago

Fixes #32.

Updates to PebbleEngine.Builder, and adds appropriate pathing to example template (hello.pebble).

The default constructor for PebbleTemplateEngine now does not specify a loader, so we default to PebbleEngine's DelegatingLoader as consequence.

celestialorb commented 8 years ago

Wouldn't you also need to update the dependency in the pom.xml file to point at pebble 2.x.x? I believe that is why the CI check failed; or does this step come later?

kagolaub commented 8 years ago

You were absolutely right, thanks for the tip.

adrianmoya commented 8 years ago

This worked as a charm, after breaking my head with loader "template not found" errors. I hope it gets merged, I had to build a local copy.

Thanks for the fix

N0odlez commented 8 years ago

Yeah both will work but as soon as it is packaged up in to a war or jar only the resources folder will work and not the full path from src.

I expect @tipsy will ask this as well but can you squash your commits down?

tipsy commented 8 years ago

@KareemG Why remove the comment about where the template file is located? Add it back and I can merge it!