search

perwendel / spark

A simple expressive web framework for java. Spark has a kotlin DSL https://github.com/perwendel/spark-kotlin
Apache License 2.0
9.63k stars 1.56k forks source link

fixed service so each instance has its own instance of ExceptionMapper #1033

Closed mikosik closed 5 years ago

mikosik commented 6 years ago

First part of Issue #1010 blocks my development so I decided to fix it myself. I'm new to spark code so let me know if I missed out something.

perwendel commented 5 years ago

reviewing

perwendel commented 5 years ago

A problem is that classes like EmbeddedServerFactory (the architecture of these classes are less than optimal to say the least), etc are part of the public API and these changes change them in a non backwards compatible manner. I'm contemplating different solutions to this but have yet failed to come up with a good one.

perwendel commented 5 years ago

Thanks for commiting!