search

perwendel / spark

A simple expressive web framework for java. Spark has a kotlin DSL https://github.com/perwendel/spark-kotlin
Apache License 2.0
9.64k stars 1.56k forks source link

Each service has own static file location #1036

Closed lucystevens closed 5 years ago

lucystevens commented 5 years ago

Fixes issues #1031 and #1005 where multiple static file locations in different services would cause a DirectoryTraversal issue.

vladp commented 5 years ago

Thx for the fixes! hope it gets merged by @perwendel (together with another functional ehn. https://github.com/perwendel/spark/pull/980 ) .

I have been struggling to work around the problem by spawning multiple instances.

vladp commented 5 years ago

@lukecmstevens
is it possible for me to reference your build from Gradle? It does not look like any of the proposed pull requests are going to get merged in (at least within 3-4 month from the fix) -- so looking for a way forward.

lucystevens commented 5 years ago

@vladp I don't use gradle myself so I can't really help, but this stackoverflow question might be able to https://stackoverflow.com/questions/18748436/is-it-possible-to-declare-git-repository-as-dependency-in-android-gradle

vladp commented 5 years ago

thank you

From: Luke Stevens notifications@github.com Sent: Monday, August 6, 2018 5:18 AM To: perwendel/spark Cc: Vladislav P; Mention Subject: Re: [perwendel/spark] Each service has own static file location (#1036)

@vladphttps://github.com/vladp I don't use gradle myself so I can't really help, but this stackoverflow question might be able to https://stackoverflow.com/questions/18748436/is-it-possible-to-declare-git-repository-as-dependency-in-android-gradle

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/perwendel/spark/pull/1036#issuecomment-410643584, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAFyqpryJRoea_A3JnYnt6Ei5GogU7V6ks5uOAnRgaJpZM4VU4Vd.

perwendel commented 5 years ago

Thanks. Good commit!!! :)