Exception mappers not working with 2.8.0 when running on Tomcat

perwendel / spark

A simple expressive web framework for java. Spark has a kotlin DSL https://github.com/perwendel/spark-kotlin

Apache License 2.0

9.64k stars 1.56k forks source link

Exception mappers not working with 2.8.0 when running on Tomcat #1062

Open kliakos opened 5 years ago

kliakos commented 5 years ago

The issue has to do with http://sparkjava.com/documentation#exception-mapping

I have confirmed that the same code that works fine with 2.7.2, stops working with 2.8.0, when running on Tomcat. Embedded Jetty is fine though.

Instead of invoking the custom ExceptionHandler, it invokes the default one ( spark.http.matching.GeneralError ).

UshakovVasilii commented 5 years ago

Spark.exception method work with: https://github.com/perwendel/spark/blob/master/src/main/java/spark/Service.java#L88

But SparkFilter for servlet use other instance: https://github.com/perwendel/spark/blob/master/src/main/java/spark/ExceptionMapper.java#L39

Last project activity was in September, possible pull request for this problem already created.

Workaround:

  public synchronized <T extends Exception> void sevletException(Class<T> exceptionClass,
      ExceptionHandler<? super T> handler) {
    // wrap
    ExceptionHandlerImpl<T> wrapper = new ExceptionHandlerImpl<T>(exceptionClass) {
      @Override
      public void handle(T exception, Request request, Response response) {
        handler.handle(exception, request, response);
      }
    };

    ExceptionMapper.getServletInstance().map(exceptionClass, wrapper);
  }

and call sevletException with exception

    exception(Exception.class, new InternalServerErrorHandler());
    sevletException(Exception.class, new InternalServerErrorHandler());

cynthux commented 5 years ago

Is there any update on this issue? I would like to use Spark 2.8.0 because of the new awaitStop() method but I can't because of this issue. I wasn't able to apply a workaround so I moved back to 2.7.2 again.

kliakos commented 4 years ago

Any chance this will be fixed?