perwendel / spark

A simple expressive web framework for java. Spark has a kotlin DSL https://github.com/perwendel/spark-kotlin
Apache License 2.0
9.64k stars 1.56k forks source link

Use of deprecated setSoLingerTime Jetty method causes a warning. #1080

Closed skyghis closed 5 years ago

skyghis commented 5 years ago

A call to a Jetty deprecated method setSoLingerTime should be removed to avoid pollution on server initialization log :

[info] org.eclipse.jetty.util.log:193         - Logging initialized @3471ms to org.eclipse.jetty.util.log.Slf4jLog
[WARN] org.eclipse.jetty.server.AbstractConnector:450  - Ignoring deprecated socket close linger time
[info] spark.embeddedserver.jetty.EmbeddedJettyServer:142  - == Spark has ignited ...

Call done at SocketConnectorFactory.java(L105)

private static void initializeConnector(ServerConnector connector, String host, int port) {
    // Set some timeout options to make debugging easier.
    connector.setIdleTimeout(TimeUnit.HOURS.toMillis(1));
    connector.setSoLingerTime(-1);
    connector.setHost(host);
    connector.setPort(port);
}
toyg commented 5 years ago

Pinging @tipsy @perwendel easy one to merge

tipsy commented 5 years ago

Thanks, merged.

perwendel commented 5 years ago

Fixed