search

perwendel / spark

A simple expressive web framework for java. Spark has a kotlin DSL https://github.com/perwendel/spark-kotlin
Apache License 2.0
9.63k stars 1.56k forks source link

Allow configuring endpointIdentificationAlgorithm for jetty SSL #1153

Open huangminchn opened 4 years ago

tymur-berezhnoi commented 4 years ago

Looks good, but I would use openjdk9 or even openjdk11 instead of oraclejdk. If it's not possible now, lets create a separate issue/poc...

huangminchn commented 4 years ago

Looks good, but I would use openjdk9 or even openjdk11 instead of oraclejdk. If it's not possible now, lets create a separate issue/poc...

@t-jd Hi Tymur, thanks for reviewing. I have addressed your comment; could you please take another look?

huangminchn commented 4 years ago

Hi, can we get some traction on this PR please?

tipsy commented 4 years ago

Sorry @huangminchn, this repo is not actively maintained at the moment.

tymur-berezhnoi commented 4 years ago

@huangminchn looks good, but still the build is failed, at least Travis CI says so

huangminchn commented 2 years ago

Closed by mistakes. Reopening it.

huangminchn commented 2 years ago

@t-jd Hi Tymur, could you please take another look? Thanks!

huangminchn commented 1 year ago

@t-jd Hi Tymur, it would be great if you could take another look. Thanks!

tymur-berezhnoi commented 1 year ago

@huangminchn Looks good 👍

huangminchn commented 1 year ago

Thanks @t-jd ! Could you please approve the PR? https://github.com/perwendel/spark/actions/runs/2694031124

tymur-berezhnoi commented 1 year ago

@huangminchn I don't see how can I approve this PR. There is no action button to approve, bit only for a specific commit

huangminchn commented 1 year ago

@t-jd At the bottom of this PR page, it said "1 workflow awaiting approval". Could you please click on it and approve it?

tipsy commented 1 year ago

@huangminchn, @t-jd is not a maintainer, so he is not able to approve your PR. @perwendel is the main maintainer, and he has been active lately, so hopefully he can approve the run :)

huangminchn commented 1 year ago

Good to know that! @perwendel Could you please approve the run? Thanks!

lepe commented 1 year ago

PR merged into/solved in the unofficial build - Release 2+

huangminchn commented 1 year ago

PR merged into/solved in the unofficial build - Release 2+

Thanks @lepe ! Can you help merge it into this repo? Are you planning to release the unofficial build?

lepe commented 1 year ago

@huangminchn Yes, I have been releasing the unofficial build. To use it:

<dependency>
  <groupId>com.intellisrc</groupId>
  <artifactId>spark-core</artifactId>
  <version>2.9.4-unofficial-4</version>
</dependency>

There should not be any impact in your code (except the dependency).

Please take a minute to read which modifications, features and bug fixes are included or the summary of all the pull requests already added.

I would be happy to help to merge those changes into this repo, as I don't want to create a divergence. However it doesn't depend on me, as I'm not part of the maintainers team. Meanwhile, I will continue maintaining my branch. You are welcome to help adding new features, PMs or fixing bugs.

There are still some things I would like to update:

nmondal commented 1 year ago

@lepe : my fork use Jetty 11. Should I move to Jetty 12? I mean I can, I have no qualm about moving ... 🤣

nmondal commented 1 year ago

@lepe : I tried to migrate. And this happened: https://github.com/eclipse/jetty.project/issues/7638 Handlers are an issue. We must wait a bit, I suppose, to avoid overwork. There are alpha1 versions of ee9 and ee10.

lepe commented 1 year ago

@lepe : my fork use Jetty 11. Should I move to Jetty 12? I mean I can ... I tried to migrate. And this happened ...

Great! Thanks for trying.

Checking again, it seems that HTTP/3 was implemented in Jetty 10.0.8/11.0.8. So Jetty 11 should be enough for now. I will start working on merging your changes into the unofficial build and implementing HTTP/3 as soon as possible. :+1: