Fix issue 986 & 1146 - Githubissues

perwendel / spark

A simple expressive web framework for java. Spark has a kotlin DSL https://github.com/perwendel/spark-kotlin

Apache License 2.0

9.63k stars 1.56k forks source link

Fix issue 986 & 1146 #1171

Open WingChan1999 opened 4 years ago

WingChan1999 commented 4 years ago

Fix issue 986: Web socket request gets handled by get route
Fix issue 1146: Spark.webSocketIdleTimeoutMillis should handle Long instead of Integer

perwendel commented 4 years ago

I did an initial review of this and it looks good. There are some backwards compatibility issues I'll have to think about how to solve before merging it.