search

perwendel / spark

A simple expressive web framework for java. Spark has a kotlin DSL https://github.com/perwendel/spark-kotlin
Apache License 2.0
9.63k stars 1.56k forks source link

HTTP 2 Support #1183

Open luneo7 opened 3 years ago

luneo7 commented 3 years ago

Picked up from where https://github.com/perwendel/spark/pull/514 left, updated the code so it works with the current Jetty version being used. Added tests, a http2 client using Jetty for testing and also support for HTTP 2 clear protocol so people can also leverage HTTP 2 benefits when not using SSL.

People can also test it using JitPack

And after https://github.com/grpc/grpc-java/pull/4738 is merged (https://github.com/grpc/grpc-java/issues/1621) we can also add the possibility of running gRPC on top of HTTP/2

perwendel commented 3 years ago

@luneo7 this looks very promising. Thanks for contributing!! I will start reviewing it. One small thing, it'd be great if you could use the same import order as used in the Spark codebase since the changes makes the diff harder to read. Thanks!

luneo7 commented 3 years ago

@perwendel I reverted to the original import order =]

perwendel commented 3 years ago

@luneo7 great! :)

Safiullahkha commented 2 years ago

I want to learn hacking.

lepe commented 1 year ago

@luneo7 I have applied this PR into the unofficial release-3 (all tests passing). Feel free to give it a try. Thank you!