search

perwendel / spark

A simple expressive web framework for java. Spark has a kotlin DSL https://github.com/perwendel/spark-kotlin
Apache License 2.0
9.65k stars 1.56k forks source link

Consider breaking Spark into several artifacts #653

Open jakaarl opened 8 years ago

jakaarl commented 8 years ago

Currently, Spark is a single blob, with loads of Jetty dependencies, even though it can be run without Jetty.

It would be nice, if Spark core would be independent of Jetty (this would require dependencies on javax.servlet etc.). Embedded mode using Jetty (say, "spark-embedded"?) would have the Jetty dependencies, and even it could exclude some additional modules for less frequently used features (for example, "spark-websockets"?).

Does this sound technically impossible or somehow undesirable?

ph-hs commented 8 years ago

I like the simplicity as it is now. If I'd want to use/deploy with less, I would use Maven's <excludes> capability inside <dependency>

ruurd commented 8 years ago

Using exclude for that is crude and really not the raison-d'etre of exclusions. Meaningful decomposition would be a Good Thing (TM) I think. Separating out the Jetty dependencies might make spark more broadly applicable.

jakaarl commented 8 years ago

See PR: #674