search

perwendel / spark

A simple expressive web framework for java. Spark has a kotlin DSL https://github.com/perwendel/spark-kotlin
Apache License 2.0
9.64k stars 1.56k forks source link

Expose Request.matchuri() #959

Closed codefromthecrypt closed 5 years ago

codefromthecrypt commented 6 years ago

The templated route uri looks like a decent choice for a low-cardinality grouper for metrics and traces. Seems like Request.matchuri() could be exposed (albeit nullable) to suit the job. This could be used in tools like zipkin and micrometer https://github.com/micrometer-metrics/micrometer/blob/master/micrometer-spring-legacy/src/main/java/io/micrometer/spring/web/servlet/WebMvcTags.java#L81

codefromthecrypt commented 6 years ago

FYI I will go with a reflection approach for now as it seems not great to have spark based web requests look not as good as others in tracing

codefromthecrypt commented 6 years ago

Actually I'm not clever enough to figure out how to do this without bytecode.

I've considered making my own wrapper for Request, but that would be fragile to versions (unless it is expected to have no new methods added). A reflective proxy could also work, but I don't know if I can ever control the type of request (as filters in spark are callbacks, not interceptors). The failed idea here is hooking into Request.changeMatch and stashing matchuri temporarily as a request attribute.

Only other thing could be to hook into Access.changeMatch, which for bytecode is a cleaner way to accomplish the same.

Please ping back if anyone knows any other options, or if someone believes that exposing this is likely to happen (even if that answer is pull requests welcome)

tipsy commented 6 years ago

I don't see why this shouldn't be included, I'll merge a PR if you create one.

tipsy commented 5 years ago

This has been merged now!