search

perwendel / spark

A simple expressive web framework for java. Spark has a kotlin DSL https://github.com/perwendel/spark-kotlin
Apache License 2.0
9.64k stars 1.56k forks source link

Provide Automatic-Module-Name attribute in MANIFEST.MF #961

Open orionll opened 6 years ago

orionll commented 6 years ago

Please, provide a stable automatic module name for Spark, so it can be reliably used as a module. This is very easy:

<plugin>
    <groupId>org.apache.maven.plugins</groupId>
    <artifactId>maven-jar-plugin</artifactId>
    <version>3.0.2</version>
    <configuration>
        <archive>
            <manifestEntries>
                <Automatic-Module-Name>spark</Automatic-Module-Name>
            </manifestEntries>
        </archive>
    </configuration>
</plugin>

I recommend to make another release of Spark 2 (e.g. Spark 2.7.2) with this attribute.

nipafx commented 6 years ago

I'm totally in favor of this, but maybe spark is not the best module name. While it does align with the top-level package it goes against the reverse-domain-name strategy recommended for modules. On the other hand, that's also recommended for packages and you decided against that. :wink:

Aligned with your Maven coordinates, I recommend com.sparkjava.core or just com.sparkjava.

orionll commented 6 years ago

Any progress?