Closed philbarker closed 6 days ago
Proposal:
To address the first point: change the five "digit" code from ^\d{5}$
to ^[\dPKG]{5}$
in the Course Five Digit SCED Code and at the start of the Course SCED Code properties. This allows 5 characters which must be any digit or the letters P,K or G, so allows grade levels PK and KG mentioned in CEDS. This will also allow some codes that are invalid, e.g. with KP, GG and so on, but will catch other errors like "WRONG" and "VALID" :-) so it's better than just allowing any five characters. Note that the current regex also allowed nonsensical grade spans such as "grade 31 to 2" so this isn't any worse than what we have.
To address the second point we could raise a WARNING rather than an ERROR message for those that don't match. It's either that or don't validate it beyond allowing any 12 characters starting with the five character code. I suggest we start with a WARNING and if it proves to be problematic in practice we can loosen the validation rules.
Via @4pins :