search

peschuster / wireshark-atem-dissector

Wireshark dissector for Blackmagic Design ATEM video switcher protocol.
49 stars 15 forks source link

CSSc and SSrc commands are outdated #2

Open claudiocabral opened 5 years ago

claudiocabral commented 5 years ago

In the latest firware, Border related controls were removed from CSSc and SSrc commands. Instead, we have the new CSBd and SSBd commands. I still haven't cheked their structure, so I don't know if it's just a copy paste of the removed sections or if there's anything new. If you're still maintaining this package, I'd love to submit a pull request as soon as I have something to share

Julusian commented 5 years ago

You are correct, and dont forget that a ssrc id field has been added near the beginning of the commands too. I can confirm it is a cut and paste of structure, you an see the different versions in javascript form here: https://github.com/nrkno/tv-automation-atem-connection/blob/develop/src/commands/SuperSource/SuperSourcePropertiesCommand.ts

peschuster commented 5 years ago

It would be great if you could create a pull request. I haven't used v8 yet and only occasionally have access to a unit with 2 M/Es and SuperSource, but maybe you could include a pcap file with an example.

claudiocabral commented 5 years ago

I'll check with my boss what the priorities are, but in any case I'll some free time next week that I can use on it. How would you like me to include the pcap example file?

I'm testing out the protocol looking for any changes, please let me know in you guys are aware of anything else

peschuster commented 5 years ago

You could just add it to the examples directory. I just recently created it and uploaded a capture file I had lying around.

claudiocabral commented 5 years ago

So, after a month I've finally been reassigned to work with this. I saw that you generated the fields, could you explain what process you normally use to add changes?

peschuster commented 5 years ago

I did the initial version by generating the code with some scripts from the HTML "spec", but all the latest additions were done manually. Just edit the lua source.