search

peshay / btcde

A Python Module for Bitcoin.de Trading API
MIT License
38 stars 24 forks source link

fix issue #12 #25

Closed ghgh2 closed 6 years ago

ghgh2 commented 6 years ago

fix issue #12

codecov[bot] commented 6 years ago

Codecov Report

Merging #25 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #25   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines         486    485    -1     
=====================================
- Hits          486    485    -1
Impacted Files Coverage Δ
btcde.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3bc4e27...2bda3dd. Read the comment docs.

peshay commented 6 years ago

It takes me a while to really merge this fix, because I want an additional test with it. So I have to see how I can Mock the initial error in order to see if it comes up or not and add that to the testing suite.

peshay commented 6 years ago

Thanks for the input, I created an additional test to your change and therefore made my own commit 5e6bd0fae5f334b8bab94e35cb3233aa00755f48