peshay / btcde

A Python Module for Bitcoin.de Trading API
MIT License
38 stars 24 forks source link

Existing security issues #40

Open guardrails[bot] opened 5 years ago

guardrails[bot] commented 5 years ago

:warning: Here are the existing security issues we detected on your default branch:

Insecure Network Communication (3) - [/btcde.py:146](https://github.com/peshay/btcde/blob/b9174c8cdb72031ed5319956c3bd0b42c474a95e/btcde.py#L146) - [/btcde.py:149](https://github.com/peshay/btcde/blob/b9174c8cdb72031ed5319956c3bd0b42c474a95e/btcde.py#L149) - [/btcde.py:152](https://github.com/peshay/btcde/blob/b9174c8cdb72031ed5319956c3bd0b42c474a95e/btcde.py#L152) More info on how to fix Insecure Network Communication in [Python](http://docs.guardrails.io/vulnerabilities/py/insecure_network_communication.html?utm_source=ghpr).
CosmicDuck commented 2 years ago

Hello,

simply replacing False by True was working for me. So the fix should be easy, isn't it?

peshay commented 2 years ago

Hi! I recently put not much time into this project. There is also a PR that show a good option: https://github.com/peshay/btcde/pull/58 I think it would really be good to replace it with an option in the Connection object in line 110:

 def __init__(self, api_key, api_secret, ssl_verify=False):

So at later lines this variable can be used.

Despite this is just a hobby and I have no contributors, I have certain expectations to a PR. Because I set everything up with unit test, I also want for every change