search

peshay / btcde

A Python Module for Bitcoin.de Trading API
MIT License
38 stars 24 forks source link

tradingpair xrpeur #56

Closed marionet closed 1 year ago

marionet commented 3 years ago

How can the tradingpair xrpeur be added?

CosmicDuck commented 2 years ago

Simply add xrp and xrpeur to the existing values?

`

… TRADING_PAIRS = ['btceur', 'bcheur', 'etheur', 'btgeur', 'bsveur', 'ltceur', 'xrpeur', 'iotabtc', 'dashbtc', 'gntbtc', 'ltcbtc'] ORDER_TYPES = ['buy', 'sell'] CURRENCIES = ['btc', 'bch', 'eth', 'btg', 'bsv', 'ltc', 'iota', 'dash', 'gnt', 'xrp'] … `

Using showDeposits('xrp') is working. showRates('xrpeur'), too.

peshay commented 2 years ago

Can you create a PR for it, with a unit test and documentation about that function in the README?

CosmicDuck commented 2 years ago

Hello,

I see there is already an existing pull request which contains integration of xrp and doge in #58 additionally to ssl-verify warning pr. So I will not add more work for these issue.

cj4c0b1 commented 1 year ago

it's done on #59 we can close this.