peshay / btcde

A Python Module for Bitcoin.de Trading API
MIT License
38 stars 24 forks source link

add ssl_verify #60

Closed cj4c0b1 closed 1 year ago

cj4c0b1 commented 1 year ago

add ssl_verify option - Set to True or False to enable or disable SSL verification

`(.venv) ~/btcde$ pytest tests/ =================================================================================== test session starts =================================================================================== platform linux -- Python 3.11.2, pytest-7.4.0, pluggy-1.2.0 rootdir: /home/j4c0b1/btcde plugins: requests-mock-1.11.0 collected 44 items

tests/test_btcde_func.py ............................................ [100%]

=================================================================================== 44 passed in 1.49s ==================================================================================== (.venv) ~/btcde$ `

cj4c0b1 commented 1 year ago

Just one more comment on this change, I'm running it for more than a week without any interruptions or errors like happen before. @peshay

peshay commented 1 year ago

@cj4c0b1 sorry, this is just a hobby project for me and my main focus is working with CI/CD tools. But here this scuritinizer wasn't working and I first had to take time to look into this to get it fixed. Can you please review your branch, since it now got merge conflicts? Edit: I believe the conflict arises because I have already merged your commits pertaining to the addition of further currencies like USDT and XRP. However, this Merge Request (MR) contains those same commits, albeit with different commit hashes.

cj4c0b1 commented 1 year ago

Sure, will do it this weekend… and submit again... will close this one for now. Well, thanks to your hobby, I'm using it to automate some stuff, as I write trading, arbitrage and lending bots… :)