[FEATURE REQ] Add Dockerfile for `grofer`

pesos / grofer

A system and resource monitoring tool written in Golang!

Apache License 2.0

352 stars 52 forks source link

[FEATURE REQ] Add Dockerfile for `grofer` #101

Closed MadhavJivrajani closed 3 years ago

MadhavJivrajani commented 3 years ago

Describe the solution you'd like Have a Dockerfile for grofer for ease of use.

docker run pesos/grofer:latest

Additional context

On initial thought, this can be done by mounting the file systems being used by gopsutil to fetch metrics, /proc and /sys might be a good starting point.

Samyak2 commented 3 years ago

I looked this up a bit, haven't tried any of this yet. Apparently, mounting /proc inside the container does not provide details of the host. The alternative is to mount the whole root FS as read-only in the container (ref).

It might be only for the hostname, I'm not sure yet. I can take up this issue if no one else has taken it up for a few days.

MadhavJivrajani commented 3 years ago

Ohhh that makes sense, hmm, my bad

Mounting the whole root file system could be an option, maybe qualifying the mount as read only as well.

MadhavJivrajani commented 3 years ago

Okay so I did a little digging, cAdvisor also mounts the entire root file system for this purpose, followed by a read-only qualification. That might be the way to go!

MadhavJivrajani commented 3 years ago

@Samyak2 looks like you can take this up!