panzerox123 commented 3 years ago

Description

Adds some fields to the custom Table widget that allows control over the styling.

New type CustomColColor that stores column number and color type.
ColColor array. Appending to this array with {ColNumber: , ColColor: } will add custom colors to specified columns.
HeaderStyle to allow changing of header style
RowStyle to allow changing the default row style

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

[X] I have read the contribution guidelines and followed it as far as possible.
[X] I have performed a self-review of my own code (if applicable)
[X] I have commented my code, particularly in hard-to-understand areas (if applicable)
[X] I have run go fmt on my code (reference)
[ ] I have made corresponding changes to the documentation (if applicable)
[X] My changes generate no new warnings
[ ] Any dependent and pending changes have been merged and published

panzerox123 commented 3 years ago

Apart from the single comment, everything else looks good! I'll try testing out some weird cases locally before approving and merging.

Cool!

Gituser143 commented 3 years ago

Screenshot from 2021-05-26 15-26-42

@panzerox123 Maybe remove the background highlight? Looks kinda weird I feel...

panzerox123 commented 3 years ago

@panzerox123 Maybe remove the background highlight? Looks kinda weird I feel...

My only concern is that it can get hard to read

Gituser143 commented 3 years ago

@panzerox123 Maybe remove the background highlight? Looks kinda weird I feel...

My only concern is that it can get hard to read

Wait can't it be made same colour as rest of row when selected?

panzerox123 commented 3 years ago

Ohh yeah ofcourse! I thought you wanted the column to have the same color throughout . I'll change it tomorrow!

panzerox123 commented 3 years ago

I believe this is what you meant?

Gituser143 commented 3 years ago

I believe this is what you meant?

Yes! Looks great!