pesos / grofer

A system and resource monitoring tool written in Golang!
Apache License 2.0
352 stars 52 forks source link

UI Refactor #130

Closed panzerox123 closed 3 years ago

panzerox123 commented 3 years ago

Description

Scope of PR:

Gituser143 commented 3 years ago

@panzerox123 it looks like all the other images have to be updated too, let's finish the UI refactor with this PR along with the colour scheme changes and then update the images?

panzerox123 commented 3 years ago

Yep! That's what I'm waiting for!

MadhavJivrajani commented 3 years ago

Please retitle PR and update description accordingly. Also rebase if possible, quite a lot of changes just got merged.

Gituser143 commented 3 years ago

@MadhavJivrajani @Samyak2 I think this is ready for a review.

Gituser143 commented 3 years ago

The UI changes look nice! Just a few thoughts and nitpicks.

In the CPU graph, both CPU 0 and 7 are represented in red for me (tested on two different terminals - kitty and guake). Is this because the colors loop after 7? image

nitpick: The Ds, Ms, Ss looks a little weird. I personally like 4 d 0 H 6 M 43 s better. What do you think? image

As for the first point, the colour is selected from ui.StandardColors. This assigned as page.CPUChart.LineColors[cpu] = ui.SelectColor(ui.StandardColors, i). So there is an overlap.

The second point does make sense, will change soon. Also will update CPU % usages on labels.