Closed panzerox123 closed 3 years ago
@panzerox123 it looks like all the other images have to be updated too, let's finish the UI refactor with this PR along with the colour scheme changes and then update the images?
Yep! That's what I'm waiting for!
Please retitle PR and update description accordingly. Also rebase if possible, quite a lot of changes just got merged.
@MadhavJivrajani @Samyak2 I think this is ready for a review.
The UI changes look nice! Just a few thoughts and nitpicks.
In the CPU graph, both CPU 0 and 7 are represented in red for me (tested on two different terminals - kitty and guake). Is this because the colors loop after 7?
nitpick: The
Ds
,Ms
,Ss
looks a little weird. I personally like4 d 0 H 6 M 43 s
better. What do you think?
As for the first point, the colour is selected from ui.StandardColors
. This assigned as page.CPUChart.LineColors[cpu] = ui.SelectColor(ui.StandardColors, i)
. So there is an overlap.
The second point does make sense, will change soon. Also will update CPU % usages on labels.
Description
Scope of PR:
help
anderrorBox
) to useTable
instead ofList
.general
page and use common scrollable widget.README.MD
with images of the new UI.